Fix version text with go install
#278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Metrics Report
Details | | main (b4e8f00) | #278 (3e2c85a) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 65.3% | 65.3% | +0.0% |
| Files | 77 | 78 | +1 |
| Lines | 13803 | 13809 | +6 |
+ | Covered | 9019 | 9024 | +5 |
+ | Code to Test Ratio | 1:0.3 | 1:0.3 | +0.0 |
| Code | 42413 | 42453 | +40 |
+ | Test | 15913 | 15932 | +19 |
+ | Test Execution Time | 7m4s | 6m54s | -10s |Code coverage of files in pull request scope (0.0% → 83.3%)
Reported by octocov |
There was a problem hiding this comment.
PR Overview
This PR updates the version text reported by the generated gRPC federation-related files, replacing "dev" with "(devel)" to support the new installation mechanism using debug.ReadBuildInfo(), and adds a version command to the protoc-gen-grpc-federation plugin.
- Change version text from "dev" to "(devel)" in all generated files
- Add a version command for protoc-gen-grpc-federation
Reviewed Changes
| File | Description |
|---|---|
| _examples/11_multi_service/federation/other_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/16_code_gen_plugin/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/06_alias/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/01_minimum/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/05_async/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/02_simple/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/11_multi_service/federation/reaction_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/03_custom_resolver/federation/other_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/10_oneof/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/04_timeout/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/07_autobind/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/11_multi_service/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/14_condition/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/12_validation/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/13_map/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/09_multi_user/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/03_custom_resolver/federation/federation_grpc_federation.pb.go | (Repeated change) Updates version text from "dev" to "(devel)" |
| _examples/08_literal/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/15_cel_plugin/federation/federation_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" |
| _examples/15_cel_plugin/plugin/plugin_grpc_federation.pb.go | Updates version text from "dev" to "(devel)" in both file header and plugin version info |
Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debug.ReadBuildInfo()forgo installdev=>(devel))protoc-gen-grpc-federation